Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved deploy script pattern #64

Merged
merged 7 commits into from
Aug 15, 2024
Merged

Improved deploy script pattern #64

merged 7 commits into from
Aug 15, 2024

Conversation

MattPereira
Copy link
Member

@MattPereira MattPereira commented Jul 22, 2024 •
edited
Loading

Context

Summary

  • Imported all the deploy scripts into Deploy.s.sol so that scaffold can properly exportDeployments()
  • Moved the mock token deployments into a separate script
  • Moved the deployment of factories and hooks contracts into the pool deploy scripts that use them, which makes the required sequence of events much easier to follow

@vercel Vercel
Copy link

vercel bot commented Jul 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
scaffold-balancer-v3 ⬜️ Ignored (Inspect) Visit Preview Aug 15, 2024 4:28pm

@MattPereira MattPereira changed the title Update deploy script patterns Improved deploy script pattern Jul 22, 2024
@MattPereira MattPereira marked this pull request as ready for review August 15, 2024 16:32
@MattPereira MattPereira merged commit 7abeb10 into main Aug 15, 2024
3 checks passed
@MattPereira MattPereira deleted the improve-deploy-script-pattern branch August 16, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MattPereira